aaron-y-chen opened a new pull request, #76078:
URL: https://github.com/apache/airflow/pull/76078

   `LLMSQLQueryOperator` reads `table_names` only to introspect them through 
the hook of `db_conn_id`; the names are not passed to the model in any other 
way. Without `db_conn_id`, `table_names` can never take effect, so the 
combination is always a mistake and rejecting it breaks no working Dag. Before 
this change, the operator did not report the mistake:
   
   | Parameters | Behavior on `main` |
   |---|---|
   | `table_names` | Introspection is silently skipped. The model gets no 
schema and the task succeeds, so a column name it guesses wrong only surfaces 
when the SQL runs downstream. |
   | `table_names` + `datasource_config` | `AttributeError: 'NoneType' object 
has no attribute 'get_table_schema'` |
   
   Both now raise a `ValueError` when the Dag is parsed, the same way 
`LLMSchemaCompareOperator` checks its connection and table parameters at 
construction.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to