o-nikolas commented on code in PR #76086:
URL: https://github.com/apache/airflow/pull/76086#discussion_r4429168906
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/duckdb.py:
##########
@@ -237,6 +240,10 @@ def _provider_clauses(self, strategy: CredentialStrategy)
-> list[str]:
clauses = ["PROVIDER credential_chain"]
if self.credential_chain:
clauses.append(f"CHAIN '{self._quote(self.credential_chain)}'")
+ # Without REFRESH, DuckDB keeps the credentials it resolved at
creation for the life of
+ # the secret. DuckDB 1.2.0 and 1.2.1 do not know the option and
fail the statement.
+ if Version(duckdb.__version__) >= Version("1.2.2"):
Review Comment:
Yeah, I suppose so, by that argument we could increase to 1.5.5+
We should eventually come up with a strategy about when we upgrade that
floor (X many months, X many release, etc). For now I'll drop 1.2.0 and 1.2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
