potiuk commented on code in PR #75829:
URL: https://github.com/apache/airflow/pull/75829#discussion_r4425620889
##########
scripts/tests/ci/test_spot_interruptions.py:
##########
@@ -329,6 +334,7 @@ def test_run_pr_comments_when_listing_the_runs_fails(spot,
error, expected_ok):
[
pytest.param(("repos/x",), [SERVER_ERROR, SERVER_ERROR], 3, None,
id="retries-server-errors"),
pytest.param(("repos/x",), [SERVER_ERROR] * 3, 3, SERVER_ERROR,
id="gives-up"),
+ pytest.param(("repos/x",), [STREAM_ERROR], 2, None,
id="retries-dropped-connections"),
Review Comment:
Good call — added `test_is_transient` with your cases, plus one for a
missing `stderr` (the `or ""` fallback), so each pattern in `TRANSIENT_ERROR`
is now pinned individually rather than only through the stream-reset path in
the retry test.
---
Drafted-by: Claude Code (Opus 5.5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
