shahar1 opened a new pull request, #76119: URL: https://github.com/apache/airflow/pull/76119
Partial backport to `airflow-ctl/v0-1-test` of the enum values Airflow 3.4 servers return and 0.1.x cannot parse, following the precedent of #76076 (only the values, not the features): - `DagWarningType`: `duplicate dag id` (#68791) and `task group cycle` (#73746), plus the `<namespace>:<name>` warning types 3.4 emits for provider warnings. Without them `dags list-warning` crashes with a pydantic `ValidationError` on any 3.4 server that has a duplicate Dag id or a task-group cycle (reproduced live on `apache/airflow:3.4.0rc1-python3.12`). - Plugin destinations: `asset`, `dag_overview`, `task_overview` (#69992). Without them `plugins list` crashes on a 3.4 server that has a React or external-view plugin targeting those destinations. Unlike #76076 this edits `airflow-ctl/src/airflowctl/api/datamodels/generated.py` directly: regenerating it from this branch would require backporting the 3.4 core datamodels behind five feature PRs, which is out of scope for a patch release. The hand edit is marked in the file so the next regeneration knows to keep it. Servers on 3.2.x and 3.3.x never send these values, so their behaviour is unchanged. Tested: - `breeze testing airflow-ctl-tests`: 575 passed (new tests for both enums and for the `ns:name` pattern boundary, all failing without the change). - Model check against the 3.2.0–3.4.0rc1 OpenAPI specs: no remaining enum member missing for these models. - Live against `apache/airflow:3.4.0rc1-python3.12` with two files defining the same `dag_id`: `dags list-warning` (table and `--output json`) returns the `duplicate dag id` warning instead of a traceback; `plugins list` returns. Unchanged against 3.2.2 and 3.3.2. - `breeze testing airflow-ctl-integration-tests` against 3.2.2, 3.3.2 and 3.4.0rc1 with the three 0.1.6 fixes combined: identical results to the unpatched branch. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Fable 5.1) Generated-by: Claude Code (Fable 5.1) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
