henry3260 opened a new pull request, #76144: URL: https://github.com/apache/airflow/pull/76144
## Why `go-sdk/DEVELOPMENT.md` describes how the vendored schema copies under `go-sdk/schema/` stay in step with the Python distributions that own them. That account went stale when `sync-go-sdk-schemas` stopped being a manual hook and gained the Python schema sources as triggers, so the doc now tells a contributor the opposite of what they meet: - It says `sync-go-sdk-schemas` is a **manual** hook and that, as a result, "nothing announces on its own that a copy has gone stale" — which is precisely the gap that change closed. A reader planning around a stale copy going unnoticed plans around a problem that no longer exists. - Its two refresh commands pass `--hook-stage manual`, which no longer selects a hook that runs at the `pre-commit` stage. ## What `go-sdk/DEVELOPMENT.md` only; no code or hook changes. - **"The vendored schemas"** — both hooks are now described as running on every commit, triggered by the Python originals as well as the copies. The paragraph that explained why re-vendoring was deliberate is replaced by one that says what the Python-side trigger buys: a schema change fails on the commit that made it, and that check is the only warning there is, because a model generated from a stale copy fails at run time by not failing — msgpack drops a message field the Go struct does not declare, so the Go side quietly sees one field fewer. It also names the case the hooks cannot cover: a release branch is a partial set of cherry-picks, so each commit can pass on `main` and still land there in a combination that does not hold, which is why both hooks should be run over the whole tree before tagging. - **"Regenerating the coordinator-protocol models", step 1** — `--hook-stage manual` dropped, plus a note that a commit touching the task-sdk snapshot runs the hook for you, so the manual invocation is for a go-sdk maintainer moving the SDK forward deliberately rather than the only way it happens. - **"Regenerating the Dag, task and task group specs"** — same flag dropped. ## How I verified it - `prek run --files go-sdk/DEVELOPMENT.md` — passes (codespell, markdownlint, and the offline lychee internal-link check). - `breeze verify --base-ref upstream/main` — "No tests or docs builds to run locally for the changed files." related: #74047, #74091 --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 5) Generated-by: Claude Code (Opus 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
