austinaviv commented on PR #76132: URL: https://github.com/apache/airflow/pull/76132#issuecomment-6544131972
> The fix is correct: `ConnectTimeout`/`PoolTimeout`/`WriteTimeout`/`WriteError` now exit cleanly instead of with a traceback, the never-connected set matches `_should_retry_api_request` in `client.py`, and all 33 new test cases fail on `main` and pass on this head (370 passed locally). One nit inline; CI has not run yet (workflows awaiting approval), so this is a comment rather than an approval. > > ### Smaller observations > * See inline comments on `airflow-ctl/src/airflowctl/ctl/cli_config.py:79`. > > > _This review was drafted by an AI-assisted tool and > > confirmed by an Apache Airflow maintainer. The findings > > below are observations, not blockers; an Apache Airflow > > maintainer — a real person — will take the next look at the > > PR. If you think a finding is mis-applied, please reply on > > the PR and a maintainer will weigh in._ > > _More on how Apache Airflow handles maintainer review:_ > > [Contributing guide](https://github.com/apache/airflow/tree/main/contributing-docs). Thanks for the review. I have applied the suggestion to drop the unreachable Connect Error check from _warn_if_write_may_have_applied. All unit tests and CI checks are passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
