pavansai1997 opened a new pull request, #76161:
URL: https://github.com/apache/airflow/pull/76161
The "IdP Extra Request Parameters" field of the Google Cloud connection
never reached the
identity provider, for two independent reasons:
- The connection form and `provider.yaml` store the value under the
`idp_extra_parameters`
extra, but `GoogleBaseHook` read `idp_extra_params`, so a value entered in
the UI was
ignored.
- `_CredentialProvider` received `idp_extra_params_dict` but never passed it
to
`ClientCredentialsGrantFlowTokenSupplier`, so the parameters were dropped
even when the
hook did read them.
The hook now reads `idp_extra_parameters` and falls back to
`idp_extra_params`, the only
key that was read until now, so connections whose extras were written by
hand keep working.
Making the parameters reach the supplier exposed a third issue: the token
cache key only
included the parameter names, so two connections that differ only in a
parameter value
(for example `audience`) would have shared a cached token. The cache key now
includes the
values.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Code Puppy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
