yuseok89 opened a new pull request, #76194:
URL: https://github.com/apache/airflow/pull/76194
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related: #21867
related: #68139
A TaskGroup can now be retried as a unit with `retries`. When a task in the
group fails after its own retries and the group has retries left, all tasks of
the group are cleared and run again, as if the group were cleared by hand.
Tasks outside the group are left as they are. A retried group inside another
one is retried first, and the enclosing group takes over once it has used up
its retries.
`retry_condition`, `retry_strategy` and a delay between group retries are
left for follow-ups.
## Improvements over #68139
- Nested retried groups work again. Clearing now archives the failed
attempts and adds new ones, so the enclosing group read task instances that
were already archived and failed with `An archived task instance cannot be
cleared`. It now reads the current task instances after an inner group is
cleared.
- `retries` is rejected when the Dag is parsed in more cases. #68139 only
rejected a mapped group. A group inside a mapped group, a loop, a group inside
or containing a loop, and a group with setup or teardown tasks are rejected
too, since a retry would clear every expansion or iteration at once, and the
teardown of the cleared attempt would not run while its setup ran again.
- `retries` must be a non-negative integer. A negative value or `True` was
accepted before.
## Verified with `airflow dags test`
A group with `retries=1`, where `produce` returns two items in the first
attempt and three after, and the mapped `consume` fails for one item in the
first attempt. The group is retried once, `consume` is expanded again over
three items, all succeed, and the Dag run succeeds.
## Demo
https://github.com/user-attachments/assets/807e3086-3412-4bfe-a912-57f2256e0678
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Claude Code (Opus 5.5)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
