jason810496 commented on code in PR #70541:
URL: https://github.com/apache/airflow/pull/70541#discussion_r4435025305
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -339,6 +346,7 @@ def run(self):
@option_install_selected_providers
@option_installation_distribution_format
@option_load_example_dags
+@option_load_testing_dags
Review Comment:
If this PR is for "loading providers testing Dags" then would it be better
to include the "providers" term in the CLI flag?
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -400,6 +408,7 @@ def shell(
integration: tuple[str, ...],
keep_env_variables: bool,
load_example_dags: bool,
+ load_testing_dags: bool,
Review Comment:
I wonder would it be a good idea to follow the provider env setup that we
can specify the set of providers that we want to include.
Perhaps as an additional flag? Or we can make the current flag to accept
none, all, partial of the providers, etc.
##########
scripts/docker/entrypoint_ci.sh:
##########
@@ -239,6 +239,11 @@ SSH_CONFIG
export PYTHONPATH=${PYTHONPATH=}:/opt/airflow/providers/standard/tests
fi
+ if [[ ${LOAD_TESTING_DAGS=} == "true" || ${LOAD_TESTING_DAGS=} == "True"
]]; then
Review Comment:
How about defining the section at somewhere nearby the LOAD_EXMAPLE_DAGS one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
