bingqin2 commented on code in PR #72954:
URL: https://github.com/apache/airflow/pull/72954#discussion_r4436304321
##########
providers/google/src/airflow/providers/google/cloud/utils/credentials_provider.py:
##########
@@ -397,9 +398,19 @@ def
_get_credentials_using_credential_config_file_and_token_supplier(self):
"Credential Configuration File is needed to use authentication
by External Identity Provider."
)
+ extra_params = self.idp_extra_params_dict or {}
+ if reserved :=
sorted(RESERVED_TOKEN_REQUEST_FIELDS.intersection(extra_params)):
Review Comment:
Thanks, good catch. Fixed in 12a9bbcce4: `_CredentialProvider` now also
rejects an extra named `oidc_issuer_url` with the same `ValueError` before it
builds the supplier. The message now also points to the IdP token issue URL
field. As you suggested, I kept it out of `RESERVED_TOKEN_REQUEST_FIELDS`,
since it is not a token request field.
`test_get_credentials_using_identity_provider_rejects_reserved_extra_params`
has a new `oidc_issuer_url` case. Without the check, that case fails with the
`TypeError: got multiple values for keyword argument 'oidc_issuer_url'` you
described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
