potiuk commented on code in PR #76243: URL: https://github.com/apache/airflow/pull/76243#discussion_r4437180413
########## dev/breeze/doc/ci/08_fork_ci_for_external_contributors.md: ########## @@ -164,6 +164,13 @@ cron trigger, and selective checks force the full matrix for `schedule` events. every enabled fork would run the full canary matrix twice a day on the contributor's concurrency cap. A manual `workflow_dispatch` in a fork still runs. +The same applies to every other workflow with a `schedule` trigger: a fork that enables +Actions gets all of their crons too. Their jobs carry a job-level +`if: github.repository == 'apache/airflow'` guard, combined with +`github.event_name != 'schedule'` when the workflow has other triggers that should still run +in a fork. A new scheduled workflow needs the same guard. The guard skips the jobs but not Review Comment: Thanks! Yes, I think a hook is worth it — the doc paragraph is the only thing that tells anyone about the guard today, and after this PR all 18 workflows with a `schedule` trigger have it, so a check would only have to keep it that way. I'd keep it out of this PR, so happy to take you up on the offer for a follow-up. Roughly what I'd expect it to check: for every `.github/workflows/*.yml` with a `schedule` trigger, every job has an `if:` that contains `github.repository == 'apache/airflow'`, or `needs:` a job that does. `ci-amd.yml` / `ci-arm.yml` may need a look of their own, since the fork CI gate's `fork_schedule` rule already skips their scheduled runs in forks. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
