arxhr007 opened a new pull request, #76255:
URL: https://github.com/apache/airflow/pull/76255
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
`ListValidator` (used for `[metrics] metrics_allow_list` and
`metrics_block_list`) splits the option on commas and keeps empty entries. Each
entry is used as a regex with `re.findall(entry, name)`, and an empty regex
matches every name. So a stray comma changes the meaning of the whole list:
```python
PatternAllowListValidator("scheduler,executor").test("dagrun.duration") #
False
PatternAllowListValidator("scheduler,executor,").test("dagrun.duration") #
True - allow list filters nothing
PatternBlockListValidator("scheduler,executor,").test("dagrun.duration") #
False - every metric is dropped
PatternBlockListValidator(" ").test("dagrun.duration") #
False - blank value drops every metric
```
A trailing comma, a doubled comma or `scheduler, ,executor` is an easy thing
to leave in a config file or a Helm value, and nothing warns about it: with an
allow list the metrics you meant to exclude keep flowing, and with a block list
the metrics backend goes silent.
This drops empty entries after stripping, and a list with no entries is
treated as unset (`validate_list` is `None`), which is already the "allow
everything" path for both validators.
Tests added in `TestStatsAllowAndBlockLists`: empty entries are ignored for
both validators, and a list with no entries (`None`, `""`, `" "`, `","`, `" ,
"`) accepts every name. 11 of the new cases fail on `main` and all pass with
this change.
##### Tests run
- `shared/observability/tests/observability`: 208 passed (without
`test_otel_utils.py`, which needs `sqlalchemy` that I did not install)
- `ruff check` and `ruff format --check` on the two changed files: passed
- I did not use `breeze` or `uv run` (no Docker here, and the installed `uv`
is older than the repo requires), so I ran pytest in a plain virtualenv with
`PYTHONPATH` set to the shared library and `devel-common`. I did not run `prek`
or `mypy`.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Claude Sonnet 5.5)
Generated-by: Claude Code (Claude Sonnet 5.5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
