yuseok89 commented on code in PR #76238: URL: https://github.com/apache/airflow/pull/76238#discussion_r4438190323
########## airflow-core/src/airflow/ui/src/pages/DagsList/useRememberedFilters.ts: ########## @@ -0,0 +1,115 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { useEffect, useRef } from "react"; + +import { useLocation, useSearchParams } from "react-router-dom"; +import { useLocalStorage } from "usehooks-ts"; + +import type { FilterConfig } from "src/components/FilterBar/types"; + +import { lastFiltersKey, presetFiltersDefaultKey } from "src/constants/localStorage"; +import { SearchParamsKeys } from "src/constants/searchParams"; + +// Every URL param the filter pills own. Composite filters enumerate the params they manage +// (mapped to undefined to clear them), so their keys are present whatever the current value is. +const getFilterParamNames = (configs: Array<FilterConfig>): Array<string> => Review Comment: nit: This mirrors how `handleFiltersChange` in `useFiltersHandler` maps each filter config to its params, so a new filter type would need both kept in sync. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
