FrankYang0529 commented on code in PR #75542: URL: https://github.com/apache/airflow/pull/75542#discussion_r4438509906
########## java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/internal/ConfBinding.kt: ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.airflow.sdk.internal + +import com.fasterxml.jackson.databind.DeserializationFeature +import com.fasterxml.jackson.databind.JavaType +import com.fasterxml.jackson.databind.ObjectMapper +import com.fasterxml.jackson.databind.introspect.BeanPropertyDefinition +import com.fasterxml.jackson.databind.json.JsonMapper +import java.util.concurrent.ConcurrentHashMap + +// Other tasks in the Dag run may read keys that the target class does not +// declare, so this mapper must not fail on an unknown key. By default, Jackson +// moves a date-time that carries an offset to UTC. For example, +// 2024-01-31T02:00+08:00 would become 2024-01-30T18:00Z and fall on another +// date. This mapper keeps the offset as written instead. +private val confMapper: ObjectMapper by lazy { Review Comment: I will create a follow-up for this. Thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
