justinpakzad opened a new pull request, #76267:
URL: https://github.com/apache/airflow/pull/76267
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
#76243 Added a guard to skip scheduled workflows in forks that enable
Actions. This is a follow up PR that adds a `prek` hook to ensure any new
scheduled workflows get the same guard. A job passes when its own `if:` has the
`apache/airflow` guard, or when it needs a job that passes it and doesn't
override the skip with `always()`, `cancelled()` or `failure()`.
Couple of notes worth mentioning - The `ci-amd.yml` and `ci-arm.yml` files
exempt since they need to run in forks on push, and their `check-run-needed`
step already skips scheduled runs there. The check is textual so it catches a
missing guard, but a guard ORed with something thats true in forks (like
github.event_name == 'schedule' || ...) would still pass. None of the current
workflows do that anyway and I don't think it's worth the additional complexity
of trying to account for that.
Example (I modified some of the files locally to intentionally fail it):
<img width="1442" height="305" alt="Screenshot 2026-11-01 at 20 09 07"
src="https://github.com/user-attachments/assets/696cb90d-0c52-4422-aa46-ad8987f51029";
/>
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (Claude Opus 5.5)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
