seanghaeli commented on code in PR #76184:
URL: https://github.com/apache/airflow/pull/76184#discussion_r4445639422
##########
airflow-core/src/airflow/executors/base_executor.py:
##########
@@ -930,6 +930,7 @@ def run_workload(
dag_rel_path=workload.dag_rel_path,
log_path=workload.log_path,
bundle_info=workload.bundle_info,
+ team_name=workload.team_name,
Review Comment:
My agent flagged this one: `supervise_callback` in Task SDK 1.4.0 doesn't
take `team_name`, and core still allows `apache-airflow-task-sdk>=1.4.0`. So if
this gets backported to 3.4.x, a worker with the new core and SDK 1.4.0 fails
every executor callback with a `TypeError`, even with multi-team off. We should
only pass it when it's set, like `callback_kwargs_encoding` just above. Then
callbacks without a team keep working on any Task SDK, and a team callback on
an old SDK fails loudly instead of quietly reading the global value.
```suggestion
**({"team_name": workload.team_name} if workload.team_name
else {}),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
