aaron-y-chen commented on code in PR #74674:
URL: https://github.com/apache/airflow/pull/74674#discussion_r4436609425
##########
go-sdk/sdk/context.go:
##########
@@ -85,13 +87,22 @@ type TaskInstance struct {
}
// DagRun identifies the Dag run the current task instance belongs to and
-// carries its scheduling timestamps. The *time.Time fields are nil when the
-// supervisor did not provide a value (for example, a manually triggered run
-// without a logical date).
+// carries its scheduling timestamps, how it was created, and its conf. The
+// *time.Time fields are nil when the supervisor did not provide a value (for
+// example, a manually triggered run without a logical date).
type DagRun struct {
DagID string
RunID string
LogicalDate *time.Time
DataIntervalStart *time.Time
DataIntervalEnd *time.Time
+ RunAfter time.Time
+ // RunType says how the run was created, such as
+ // [github.com/apache/airflow/go-sdk/airflow.DagRunTypeManual].
+ RunType genmodels.DagRunType
+ // Conf is the configuration the run was triggered with. It may be nil
or
+ // empty when no configuration was supplied. The runtime copies its
nested
+ // maps and slices from the startup details. Integers are int64, except
values
+ // above math.MaxInt64, which are uint64; floating-point values are
float64.
+ Conf map[string]any
Review Comment:
Nice catch! There's an obvious contradiction in the comment. Let me fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
