[
https://issues.apache.org/jira/browse/AIRFLOW-6530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019536#comment-17019536
]
ASF GitHub Bot commented on AIRFLOW-6530:
-----------------------------------------
envious commented on pull request #7218: [AIRFLOW-6530] Add Custom Statsd Client
URL: https://github.com/apache/airflow/pull/7218
This change allows Airflow users to utilise their own custom Statsd client
as discussed [here](https://issues.apache.org/jira/browse/AIRFLOW-6530).
Many companies have their own custom Statsd clients and this change should
allow for easier adoption of Airflow by large corporations.
Example usage based off of this change:
1) User adds a module path to their airflow.cfg file next to the
'statsd_custom_client_path' key in the scheduler section of the config.
As such:
`statsd_custom_client_path = company.statsdclient.customclient`
2) Ensure the newly added client exists on the PYTHONPATH.
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Allow for custom Statsd client
> ------------------------------
>
> Key: AIRFLOW-6530
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6530
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler, webserver
> Affects Versions: 1.10.7
> Reporter: Usman Arshad
> Assignee: Usman Arshad
> Priority: Major
> Labels: features
> Fix For: 1.10.8
>
>
> We are currently using Airflow at Skyscanner and we have a custom
> implementation of Statsd which offers features which wires in nicely into our
> metrics platform/tooling.
> I'm quite sure that other companies who are using Airflow would also find
> great benefit in being able to utilise their own custom Statsd client,
> therefore i am proposing this addition.
>
> The proposed solution looks something along the lines of changing this:
> {code:java}
> statsd = StatsClient(
> host=conf.get('scheduler', 'statsd_host'),
> port=conf.getint('scheduler', 'statsd_port'),
> prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
> Into
> {code:java}
> statsd = conf.get('STATSD_CLIENT') or StatsClient(
> host=conf.get('scheduler', 'statsd_host'),
> port=conf.getint('scheduler', 'statsd_port'),
> prefix=conf.get('scheduler', 'statsd_prefix'))
> {code}
> Note: Psuedocode, not actual code
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
