justinpakzad commented on code in PR #76106:
URL: https://github.com/apache/airflow/pull/76106#discussion_r4436279665
##########
providers/snowflake/src/airflow/providers/snowflake/operators/snowpark_containers.py:
##########
@@ -123,16 +139,22 @@ def __init__(
poll_interval: int = 10,
snowflake_conn_id: str = "snowflake_default",
deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
+ durable: bool | None = None,
+ cancel_on_kill: bool = True,
Review Comment:
I've kept the cancel_on_kill=True as the default (using not durable could
cause other issues) which matches the `SnowflakeSqlApiOperator` and updated the
docs and the docstring to note that durable jobs need `cancel_on_kill=False` to
survive a graceful shutdown or pod eviction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
