potiuk opened a new pull request #7219: Revert "[AIRFLOW-6596] Enforce description should not be empty (#7211)" URL: https://github.com/apache/airflow/pull/7219 This reverts commit d553813b0c35f212b2fa10a49e6a542d23e5ee83. After few reviews, I think the description check is counter-productive. There are many commits that might not require it and it's not obvious how it should be fixed. I prefer to judge manually if more description is needed. Also we might quickly end up with bogus descriptions such as copying the title to description which is worse than not having the description. Also - I think what's really important if we want to enforce description - Then we need to make sure that description is OK in the final commit rather than in PR description. Note that PR description is not synchronised after PR is created, so if you create PR with an empty description, you have to update both description in the PR and the commit to get the desired result! --- Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg) Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup> - [x] Unit tests coverage for changes (not needed for documentation changes) - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)" - [x] Relevant documentation is updated including usage instructions. - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example). <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`. --- In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
