potiuk commented on code in PR #76225:
URL: https://github.com/apache/airflow/pull/76225#discussion_r4436951628
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -2343,6 +2343,12 @@ def debug_resources(self) -> bool:
def disable_airflow_repo_cache(self) -> bool:
return self.docker_cache == "disabled"
+ @cached_property
+ def use_pinned_os_deps_images(self) -> bool:
+ # Only the label - not the DOCKER_CACHE=disabled retry of a failed
image build - asks for the OS
+ # dependencies to be installed from scratch rather than taken from the
pinned images.
+ return DISABLE_IMAGE_CACHE_LABEL not in self._pr_labels
Review Comment:
Done in 23e750082b: a PR that changes `install_os_dependencies.sh`,
`common.sh`, `install_{mysql,mssql,postgres}.sh` or `scripts/docker/keys/` now
gets `use-pinned-os-deps-images=false`, so its OS layer is built from
`BASE_IMAGE` and removals show up — no label needed. Thanks!
---
Drafted-by: Claude Code (Claude Opus 5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
