seanghaeli commented on code in PR #76311:
URL: https://github.com/apache/airflow/pull/76311#discussion_r4449136443


##########
airflow-core/docs/core-concepts/backfill.rst:
##########
@@ -50,6 +50,33 @@ is therefore the primary lever for controlling how much of 
your scheduling capac
 backfill consumes at once — lower it to leave more room for time-sensitive 
scheduled work
 while the backfill is in progress.
 
+.. _backfill:run-timeout:
+
+Run timeouts
+------------
+
+Set ``dag_run_timeout`` when creating a backfill to override the Dag's default 
timeout for each new run.
+The limit applies separately to each run, starting when that run enters the 
``running`` state.
+It does not limit the duration of the whole backfill. See 
:ref:`dag-run:timeout` for timeout behavior.
+
+The REST API accepts an ISO 8601 duration in requests to ``POST 
/api/v2/backfills``. For example:
+
+.. code-block:: json
+
+    {
+      "dag_id": "tutorial",
+      "from_date": "2015-06-01T00:00:00Z",
+      "to_date": "2015-06-07T00:00:00Z",
+      "dag_run_timeout": "PT30M"
+    }
+
+Use ``--dag-run-timeout 1800`` with ``airflow backfill create`` for the same 
30-minute limit.
+In the UI backfill form, enter a positive number of seconds under **Dag Run 
Timeout**.
+Omit the option, use ``null`` in the API, or leave the UI field empty to 
inherit the Dag's timeout.
+
+The override applies only to newly created runs. If reprocessing clears and 
reuses an existing run,
+that run keeps its previous override or inherited default.

Review Comment:
   So the idea here is that once a run exists, its timeout never changes even 
if you supply an override, right? How come? Doesn't it make sense that if the 
user asks to override the timeout value, that it should apply to all the Dag 
runs in their request? 
   
   For example (and I tested that this happens on Breeze), re-running previous 
runs with `--reprocess-behavior failed --dag-run-timeout X` does not apply the 
new timeout. I think it could at least supply a warning to the user instead of 
dropping it quietly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to