ramitkataria opened a new pull request, #76336:
URL: https://github.com/apache/airflow/pull/76336
The `example_dms` system test intermittently fails in `await_task_start`:
DMS stops the replication task about five seconds after starting it, before it
reaches `running`, and nothing in the Dag asked it to stop. #75240 added
`StopReason` and `LastFailureMessage` to the sensor's failure message, but the
latest failure reported only `Stop Reason NORMAL` with no failure message, so
the DMS API does not tell us why. The DMS task logs are the next diagnostic
step.
This enables CloudWatch logging on the replication task. `TASK_MANAGER`
(task lifecycle, including stops) and `SOURCE_CAPTURE` (CDC startup on the
Postgres source) log at `LOGGER_SEVERITY_DEBUG`; the other components keep the
DMS default. The settings are merged into `create_task_kwargs` after the
`howto_operator_dms_create_task` snippet, the same way this file already sets
`poke_interval` and `trigger_rule` outside their snippets, so the rendered docs
do not change.
DMS writes the logs to a `dms-tasks-<replication instance identifier>` log
group. Each run creates its own replication instance, so without cleanup the
hourly test would leave one log group behind per run. A new teardown task,
which runs after the replication instance is deleted so DMS has finished
shipping the logs, prints the task log events into its Airflow task log and
then deletes the log group. I chose this over only deleting the log group
because the evidence then lands in the system test logs we already keep for
every run, and passing runs give a baseline to compare a failing run against.
The cost is one short teardown task outside the doc snippets.
Running the test now needs `logs:FilterLogEvents` and `logs:DeleteLogGroup`
on `dms-tasks-*` log groups for the test's execution role, plus the standard
`dms-cloudwatch-logs-role` for DMS.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (Claude Code Opus 5.5)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
