jedcunningham commented on code in PR #76314:
URL: https://github.com/apache/airflow/pull/76314#discussion_r4450704270
##########
task-sdk/tests/task_sdk/coordinators/java/test_coordinator.py:
##########
@@ -406,7 +426,11 @@ def test_classpath_flag_and_value_present(self, jars_dir,
java_task_handlers, mo
assert "-classpath" in cmd
cp_idx = cmd.index("-classpath")
classpath = cmd[cp_idx + 1]
- assert jars_dir.joinpath("app.jar").as_posix() in classpath
+ assert classpath == "./app.jar"
+
+ def test_runs_in_the_bundle_directory(self, jars_dir, java_task_handlers,
mock_client):
+ self._captured_popen_cmd(java_task_handlers, mock_client)
+ assert self.popen_kwargs["cwd"] == jars_dir
Review Comment:
Thanks! Added as a timestamped case of `test_runs_in_the_bundle_directory`.
##########
task-sdk/tests/task_sdk/coordinators/java/test_coordinator.py:
##########
@@ -683,8 +707,11 @@ def test_rejects_a_jar_deleted_after_discovery(self,
tmp_path):
@patch("airflow.sdk.coordinators._subprocess._set_close_on_exec_above_stderr",
autospec=True)
Review Comment:
Thanks! Added as a timestamped case of `test_parse_dag_execs_the_jvm`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
