guan404ming commented on code in PR #75820:
URL: https://github.com/apache/airflow/pull/75820#discussion_r4457743902
##########
airflow-core/src/airflow/ui/src/utils/hitl.ts:
##########
@@ -35,6 +35,18 @@ export type HITLResponseParams = {
export const isHITLPending = (state?: TaskInstanceState | null): boolean =>
state === "deferred" || state === "awaiting_input";
+// Whether an option button is styled as the main action. After a response,
the chosen options are. Before one,
Review Comment:
Maybe trim this to one line, like "Defaults apply on timeout, so they are
not highlighted."
##########
airflow-core/src/airflow/ui/src/utils/hitl.test.ts:
##########
@@ -66,6 +66,33 @@ describe("isHITLPending", () => {
});
});
+describe("isHighlightOption", () => {
Review Comment:
A case for `chosen_options: []` before a response would cover the old `??`
bug too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
