shahar1 opened a new pull request, #88:
URL: https://github.com/apache/airflow-ci-infra/pull/88

   Every job of `apache/airflow` has run on the `runs-on-flex` stack since 
2026-11-01 (apache/airflow#76239, backported to `v3-4-test`), so the `runs-on` 
CloudFormation stack is idle. This PR deletes it through the existing 
**Terraform (RunsOn)** workflow instead of a `terraform destroy` from someone's 
machine: the `aws_cloudformation_stack` resource (and the outputs that read it) 
leave the configuration, so the plan is the deletion and the apply runs it 
after the `runs-on-prod` approval, with the plan artifact and the run log as 
the record.
   
   The `runs-on-terraform-apply` role could only `UpdateStack`, so it gets 
`cloudformation:DeleteStack` on the `runs-on` stack alone. That is a separate 
statement on purpose: the `TemplateUrl` condition on the `UpdateStack` 
statement would deny a `DeleteStack`, which carries no template.
   
   RunsOn's template keeps the cache and access-log buckets on deletion 
(`DeletionPolicy: RetainExceptOnCreate`, and the [uninstall 
docs](https://runs-on.com/docs/uninstall/) say "The only retained resources 
should be the two S3 buckets"), so the delete does not fail on the non-empty 
cache bucket; the two buckets are deleted by hand afterwards.
   
   Order of operations:
   
   1. The **Terraform (RunsOn)** plan on this PR must show `Plan: 0 to add, 0 
to change, 1 to destroy.` (`aws_cloudformation_stack.runs_on`). Stop on 
anything else.
   2. An account admin applies `terraform/runs-on-access` by hand from this 
branch. Expected plan: `0 to add, 1 to change, 0 to destroy` 
(`aws_iam_role_policy.apply` updated in place).
   3. Merge; the plan on `main` must again show exactly 1 to destroy. A 
reviewer other than the merger approves `runs-on-prod`. The apply waits for the 
stack deletion (`timeout_in_minutes` 30); do not cancel it.
   4. Delete the two retained buckets (the `RunsOnBucketCache` stack output and 
the access-log bucket) by hand once the stack is gone.
   5. #87 (rebased on this) removes `terraform/runs-on`, the workflow and the 
roles.
   
   Not in this PR: emptying or deleting the retained buckets from CI; that 
would need S3 permissions on them for the apply role, for a one-off.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to