youngduck98 commented on code in PR #75608:
URL: https://github.com/apache/airflow/pull/75608#discussion_r4470256022
##########
airflow-core/src/airflow/ui/src/pages/Run/Header.tsx:
##########
@@ -63,8 +64,16 @@ export const Header = ({ dagRun }: { readonly dagRun:
DAGRunResponse }) => {
const dagId = dagRun.dag_id;
const dagRunId = dagRun.dag_run_id;
- const { data: alertData } = useDeadlinesServiceGetDagDeadlineAlerts({ dagId
});
- const hasDeadlineAlerts = (alertData?.total_entries ?? 0) > 0;
+ const { data: deadlineData } = useDeadlinesServiceGetDeadlines({
+ dagId,
+ dagRunId,
+ includeAlerts: true,
+ limit: 10,
+ orderBy: ["deadline_time"],
+ });
+ const hasDeadlineAlerts =
Review Comment:
The run header and its modal continue to show all stored deadline records
for this run, regardless of its current run type. Filtering these records by
run type could hide a stored missed deadline and show Met based only on another
applicable alert.
Only when no deadline records exist do we check the creation-version alert
definitions against the run's current type: an applicable alert retains the
existing Met display; otherwise, the Deadline field is hidden. Changing the
filter does not delete existing deadline records.
If the same run is later reprocessed as backfill, the UI simply displays the
previously stored deadline records; it does not reevaluate the backfill
execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
