xBis7 opened a new pull request, #76489:
URL: https://github.com/apache/airflow/pull/76489
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
According to the docs, the `logical_date` is an identifier with no
semantics. But in the code it has more usages than that. It seems that there is
still some behavior tied to the old functionality from when the field was named
`execution_date`.
The `logical_date` is tied to the `data_interval_start` for scheduled runs
and it can be set through a custom timetable or a manual trigger. If we set a
future value, the Dag starts running but it doesn't execute and the scheduler
logs an error `Logical date is in future: ` on every iteration until the future
date arrives. The restriction has existed since the field was named
`execution_date` and long before `run_after` was introduced.
The `run_after` field points at “when this should start”, and the scheduler
already uses it to make sure that a Dag run isn't in the future. Therefore, the
`logical_date` future restriction has become redundant and it could be removed.
The scheduler still uses the `logical_date` to order the task instances
during scheduling. If the future value constraint is removed, then `run_after`
must be used for ordering in the scheduler, otherwise a run with a future
logical date starts and then sorts behind every other run whenever slots are
contended.
With the changes in this PR,
* Future logical dates are allowed
* Future logical dates start once `run_after` passes, which for manual
triggers is the trigger time
* Slots are ordered by `run_after`
* The Logical Date task dependency no longer fails for a future date
Everything else stays the same. `logical_date` is still derived from
timetables and bound to the `data_interval_start`.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Claude code Fable 5.1
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
