KidAmnesiac1 commented on PR #74445:
URL: https://github.com/apache/airflow/pull/74445#issuecomment-6651505542

   @shahar1 thanks for the review. Both points are addressed in c1cd1e8146, and 
the branch is rebased on `main` (squashed to one commit), so CI gets a fresh 
run:
   
   - **Version:** the migration is now `0008_5_2_0_widen_edge_job_command.py` 
with `edge3_version = "5.2.0"`. `_REVISION_HEADS_MAP` keeps `"5.1.0": 
"d5a2f8b41c07"` and adds `"5.2.0": "cd96a0a0e458"` below it, and 
`migrations-ref.rst` is regenerated by the prek hook.
   - **MySQL:** `edge_job.command` uses `Text().with_variant(MEDIUMTEXT(), 
"mysql")` in the model, and the migration uses the same type in both 
`upgrade()` and `downgrade()`.
   
   @jscheffl two of the suggestions I applied from GitHub needed correcting, 
since `providers-edge3/5.1.0` shipped with `d5a2f8b41c07` as its head. The 
`migrations-ref.rst` suggestion also relabelled the `d5a2f8b41c07` 
(priority_weight) row as `5.2.0`, and the `db.py` suggestion replaced the 
`"5.1.0"` entry rather than adding `"5.2.0"` below it. Both are back to `5.1.0` 
now.
   
   The edge3 provider tests pass locally on SQLite, Postgres and MySQL, 
including the new `test_queue_workload_stores_command_longer_than_2048_chars`.
   
   Could you take another look?
   
   ---
   Drafted-by: Claude Code (Opus 5.5); reviewed by @KidAmnesiac1 before posting
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to