yuqian90 commented on issue #7139: [AIRFLOW-2279] Clear tasks across DAGs if 
marked by ExternalTaskMarker
URL: https://github.com/apache/airflow/pull/7139#issuecomment-576619381
 
 
   > @kaxil, this is the same change that you already merged. Since it's a bit 
of work to merge against v1-10-test, I put up this PR to do that. (e.g. www vs 
www_rbac are two separate packages, and there's a test which counts the number 
of example DAGs that need to be updated).
   > 
   > However, I noticed some tests time out. It doesn't look related to my 
change, e.g. test_cli.py timesout. test_external_task_sensors.py times out in 
one of the test profiles (Tests sqlite python 3.5), again I don't think it's 
due to my change. Is there some known issue with the tests in v1-10-test? The 
same tests in master seem to work just fine.
   
   Okay I found the problem with `test_external_task_sensors.py`. I need to set 
the `ExternalTaskSensor` to `mode="reschedule"` in order to pass the Travis 
test for sqlite. I did that and the test is now happy. It's interesting the 
same test passes without issue in master branch.
   
   For `test_cli.py`, I have double checked it is unrelated to my PR. I tried 
running the same test using clean `upstream/v1-10-test`, it fails too. So it's 
likely some other issue that should be addressed in a separate PR by someone 
else.
   
   @kaxil  pls take a look if you have a chance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to