shahar1 opened a new pull request, #76561:
URL: https://github.com/apache/airflow/pull/76561

   On a default install, a Param with `format="date-time"` accepts any string.
   
   `jsonschema` checks this format only when `rfc3339-validator` is installed. 
Airflow 2 declared this package. Airflow 3.0 removed it in #48007. CI did not 
find the problem, because a dev dependency of the amazon provider installs the 
package.
   
   This PR makes these changes:
   
   - Add `rfc3339-validator` to `apache-airflow-core` and 
`apache-airflow-task-sdk`.
   - Catch `ParamValidationError` on the two asset-triggered scheduler paths. 
Without this, a stored Dag with a newly invalid default makes the scheduler 
exit.
   - Always validate Params when a backfill is created. Without this, a 
backfill with no conf returns a 500 and leaves an open row.
   
   **Breaking change:** a value with no timezone offset now fails validation. A 
Dag with a schedule and an invalid default fails to import. The newsfragment 
lists all effects and the migration steps.
   
   Do not backport this change to a patch release.
   
   **Checks:** these ran on SQLite with `uv run`. `breeze` did not run, because 
the local sandbox refuses its Docker build.
   
   - Tests pass for `test_param.py` (core and Task SDK), `test_backfill.py` and 
`test_backfills.py`. `test_scheduler_job.py` passes for `-k "asset or 
partition"`.
   - Each new test fails without its change.
   - The new `try` block adds no measurable scheduler time (`timeit` median: 
29.6 ns before, 28.2 ns after).
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01BVx6g8A3doAQCz2buBCPa2
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to