aarmens702-hub commented on code in PR #76389:
URL: https://github.com/apache/airflow/pull/76389#discussion_r4489249198
##########
providers/common/ai/tests/unit/common/ai/utils/test_file_analysis.py:
##########
@@ -397,6 +397,27 @@ def test_csv_sample_rows_is_configurable(self, tmp_path):
assert "beta, 2" not in request.user_content
assert "gamma, 3" not in request.user_content
+ def test_csv_values_keep_their_quotes(self, tmp_path):
+ path = tmp_path / "people.csv"
+ path.write_text(
+ 'name,city,note\n"Smith, John","Vancouver, BC","said ""hi""\nthen
left"\n', encoding="utf-8"
Review Comment:
Good catch, thanks. The line break case was the one the old test couldn't
distinguish. I split it up in be4d47e1e: the test is now parametrized with one
value per trigger (comma, quote, line feed, carriage return), plus a plain
value that shouldn't be quoted. Removing any of those characters from
`_join_csv_values` now fails its own case.
Drafted-by: Claude Opus 5.5; reviewed by @aarmens702-hub before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
