aaron-y-chen opened a new pull request, #76632:
URL: https://github.com/apache/airflow/pull/76632

   After #73517 added `S3RemoteLogIO.stream()`, 
`FileTaskHandler._read_remote_logs()` returns a generator of log lines for S3 
logs. The integration test still compares that generator directly with a 
string, causing consistent core CI failures.
   
   Consume the stream within the existing `mock_aws()` context and compare its 
lines with the expected content.
   
   Failed log:
   ```console
   FAILED 
airflow-core/tests/unit/utils/test_log_handlers.py::TestFileTaskLogHandler::test_read_remote_logs_with_real_s3_remote_log_io
 - AssertionError: assert equals failed
     <generator object S3RemoteLogIO._get_log_stream at 0xff21ccf3dc60>  'Log 
line 1 from S3\nLog line 2 from S3\nLog line 3 from S3'
   ```
   
   https://github.com/apache/airflow/actions/runs/42280521709/job/128113263198
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [x] Yes (please specify the tool below)
   
   Generated-by: [Claude] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [PR] Fix S3 remote log test f... aaron-y-chen (via GitHub) via commits

Reply via email to