czhang06 opened a new pull request, #76572: URL: https://github.com/apache/airflow/pull/76572
`_reload_tis_with_rendered_fields` didn't load `task_instance_note`, so endpoints that use it (clear task instances, patch task instance, patch task group, and their dry runs) made one note query per task instance when building the response, an N+1. I added `joinedload(TI.task_instance_note)` to the reload. I also added a `session.flush()` before it: the reload uses `populate_existing=True`, so without the flush a note that was just set but not yet saved got overwritten with the old value from the database (this broke `test_patch_task_group_note_only`). The clear endpoint already flushed before reloading for this reason; now the helper does it for every caller. Added `test_dry_run_loads_notes_in_one_query`: patching a 4-task group made 4 note queries before the fix and 1 after. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Claude Code following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
