himanshuchawla0807-gif commented on PR #76290: URL: https://github.com/apache/airflow/pull/76290#issuecomment-6605201634
I independently ran the Arrow ADBC hook test module at `6e18f3b666f07f318447e578aa3aa007f65f0b2d` in local Breeze (Python 3.11.17): **22 passed, 1 warning**, including the native SQLite connection test and your four new autocommit tests. ```sh pytest providers/apache/arrow/tests/unit/apache/arrow/hooks/test_adbc.py -q ``` For a baseline comparison, I retained your tests and replaced only `hooks/adbc.py` with the version from base `27b8c82f54d44830176eb049f2e42916c7849bb0`. The four selected new tests failed: default preservation raises `NotSupportedError: autocommit only`; the disabled-driver-default control observes an unwanted `set_autocommit(False)` call; the two explicit-argument cases reject the new keyword because that API is absent on base. Those last two are API-addition checks, rather than independent reproductions of the original defect. I restored the exact head source afterward. Environment caveat: the reused local CI image initially failed during setup because its FastAPI 0.136.3 lacked `iter_route_contexts`. Installing the PR lockfile's `fastapi==0.162.0` inside the disposable test container allowed the run above; I did not rebuild the complete current-tip image. This is focused module validation, with a mocked autocommit-only boundary, **not a live Redis driver/connection-construction test or full-suite/merge-readiness claim**. Disclosure: Codex inspected and executed this verification and drafted this comment. No personal human review is claimed; the implementation and regression tests are yours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
