ferruzzi commented on code in PR #76624:
URL: https://github.com/apache/airflow/pull/76624#discussion_r4496515773
##########
dev/breeze/tests/test_release_management_commands.py:
##########
@@ -394,7 +394,11 @@ def test_prepare_provider_distributions_skip_git_fetch(
assert len(fetches) == expected_fetches
Review Comment:
Non-blocking: Claude caught this one: These are all already tested in
`[test_git_remotes.py:33-34](https://github.com/apache/airflow/blob/92b4e57df135deb1f460c6797bd95c0088914594/dev/breeze/tests/test_git_remotes.py#L30)`
but neither tst is covering the fall-through to `origin/apache`, or the
`ValueError` when no remote matches. Might be worth consolidating the tests
and/or adding those cases.
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1557,7 +1558,7 @@ def tag_providers(
# stdout for every remote, which would make the search below
find nothing.
dry_run_override=False,
)
- if "apache/airflow.git" in result.stdout:
+ if (get_github_repo(result.stdout.strip()) or "").casefold() ==
"apache/airflow":
Review Comment:
Out of scope here but there is a parallel bug in
`[dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:91](https://github.com/apache/airflow/blob/92b4e57df135deb1f460c6797bd95c0088914594/dev/breeze/src/airflow_breeze/commands/release_candidate_command.py#L91)`
which is using pattern matching and would benefit from the same move to using
`get_github_repo()`. Might be worth a follow-up
[Claude found it and I've verified it]
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -1557,7 +1558,7 @@ def tag_providers(
# stdout for every remote, which would make the search below
find nothing.
dry_run_override=False,
)
- if "apache/airflow.git" in result.stdout:
+ if (get_github_repo(result.stdout.strip()) or "").casefold() ==
"apache/airflow":
Review Comment:
Nit: the hardcoded "apache/airflow" here should be
`APACHE_AIRFLOW_GITHUB_REPOSITORY` (already imported)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
