shahar1 opened a new pull request, #76662:
URL: https://github.com/apache/airflow/pull/76662

   Remove the five asset state store commands (`assets list-state-store`, 
`get-state-store`, `set-state-store`, `delete-state-store`, 
`clear-state-store`) from `airflow-ctl/v0-1-test`, so they do not ship in 
0.1.6. This reverts #72742 (the backport of #70771) and #76122 (its e2e version 
gate).
   
   Why these commands, and not the other features on the branch:
   
   - They do not work with every server 0.1.6 targets. The routes are absent 
from the Airflow 3.2.2 OpenAPI spec and first appear in 3.3.0. The dev@ plan 
for 0.1.6 said it works with 3.2, 3.3 and 3.4.
   - Their names are not settled. #75703 is open on `main` and moves them to 
`assets state-store …`, on the stated basis that they "have never been 
released". Shipping them in 0.1.6 would turn that into a breaking rename.
   
   The other features on the branch stay: `dags state`, `dagrun delete`, and 
`tasks states-for-dag-run` with `tasks clear` and `taskinstances list`. They 
use routes that exist on 3.2.2, and their shape on `main` is unchanged. The 
dev@ plan said "fixes only", so they need disclosing in the release notes and 
on dev@.
   
   The tradeoff: users on Airflow 3.3 get these commands only from a later 
release. If that release requires a 3.4 server, 3.3 users do not get them from 
airflowctl at all.
   
   What differs from a plain `git revert`, because later commits touched the 
same code:
   
   - `"clear"` stays in `auth_environment_command_list`, because `tasks clear` 
needs `--env`. `"set"` goes, because no other operation uses it.
   - `datamodels/asset_state_store.py` is deleted too. #70724 added that file, 
so reverting #72742 does not remove it.
   - `test_delete_queued_events`, `test_delete_dag_queued_events` and 
`test_delete_queued_event` stay. They were added later by #76044, next to the 
removed tests.
   - The older e2e skip and `pytest.param` handling that #76122 had replaced 
are not restored.
   
   `output_assets.svg` and the `assets` line in `command_hashes.txt` return to 
their values from before the feature. The regenerated help matches them 
exactly. Other hashes on this branch are out of date already and are left alone.
   
   Checks run on this branch:
   
   - `uv run --project airflow-ctl pytest airflow-ctl/tests`: 737 passed.
   - `breeze testing airflow-ctl-integration-tests`: 169 passed on each of 
Airflow 3.2.2, 3.3.2 and 3.4.0, using a non-default API port because 8080 is 
taken on this machine.
   - ruff format and check on the changed Python files, plus the commit's prek 
hooks. `mypy-airflow-ctl` was skipped because it already fails on this branch, 
and `generate-airflowctl-help-images` because the images were regenerated by 
hand.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01BVx6g7KmWF85LLcp9bDDGL
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to