potiuk commented on a change in pull request #7206: [AIRFLOW-6591] Add cli
option to stop celery worker
URL: https://github.com/apache/airflow/pull/7206#discussion_r369223989
##########
File path: airflow/cli/commands/celery_command.py
##########
@@ -23,8 +23,10 @@
from typing import Optional
import daemon
+import psutil
from celery.bin import worker as worker_bin
from daemon.pidfile import TimeoutPIDLockFile
Review comment:
Agree. I looked at what celery uses and it's also PidFile under the hood +
atexit removal of the lock, so I am perfectly OK.
https://github.com/celery/celery/blob/71d024446bbe3e0c9cdffe63fda2c83db42c7fc3/celery/platforms.py#L258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
