shahar1 commented on PR #76663: URL: https://github.com/apache/airflow/pull/76663#issuecomment-6707883302
Thanks for the review! Yes, #70954 is left out of 0.1.x on purpose. On `main`, the datamodels follow the newest API spec, so servers on older lines omit fields the models require (`is_backfillable`, `timetable_periodic`), and #70954 fixes that. On this branch, #71094 regenerated the datamodels from the Airflow 3.2.1 spec, so those fields are not in the models at all. I compared the response schemas of the supported servers with the branch models. Airflow 3.2.0, 3.3.2 and 3.4.0 return every field the branch models require (3.2.0 and 3.2.1 have identical required response fields), and the e2e suite passes on 3.2.2, 3.3.2 and 3.4.0. So the failure #70954 fixes cannot happen there. It can happen against Airflow 3.1: for example `dags get` and `assets get` fail, because `timetable_partitioned` and `watchers` are required in the models but absent from 3.1 responses. 0.1.5 requires the same fields, so this is not a regression in 0.1.6. A backport would rewrite 46 response paths in `operations.py` (+159/-95) late in the release, only for servers older than the line this branch targets. The fix ships in 0.2.0. --- Drafted-by: Claude Code (Opus 5.5); reviewed by `shahar1` before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
