yuseok89 commented on code in PR #76358:
URL: https://github.com/apache/airflow/pull/76358#discussion_r4463861872
##########
providers/http/src/airflow/providers/http/triggers/http.py:
##########
@@ -240,6 +242,7 @@ def __init__(
self.extra_options = extra_options or {}
self.http_conn_id = http_conn_id
self.poke_interval = poke_interval
+ self.response_error_codes_allowlist =
tuple(response_error_codes_allowlist or ("404",))
Review Comment:
The sensor docs say `[]` makes a 404 raise as well, but `or` turns the empty
tuple from the sensor back into `("404",)`, so a deferred sensor keeps retrying
404s. This was also the main point of the review on #69904.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
