sdaberdaku commented on code in PR #76749:
URL: https://github.com/apache/airflow/pull/76749#discussion_r4518950331


##########
chart/values.yaml:
##########
@@ -646,6 +646,12 @@ workers:
       failureThreshold: 5
       periodSeconds: 60
       command: ~
+      # Grace period for a kill triggered by this probe. Unset, the pod's
+      # `terminationGracePeriodSeconds` applies, which workers often set to 
hours
+      # so that a rolling update drains running tasks; a worker killed because 
it
+      # stopped answering is not draining anything, so a shorter period here
+      # restarts it sooner.

Review Comment:
   It is possible for Celery workers to enter warm shutdown and hang even if no 
tasks are running in some cases, which forces one to wait until the grace 
period expires.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to