amoghrajesh commented on code in PR #76575:
URL: https://github.com/apache/airflow/pull/76575#discussion_r4520296452


##########
dev/registry/registry_contract_models.py:
##########
@@ -146,6 +146,11 @@ class ModuleContract(BaseModel):
     provider_name: str | None = None
     supports_durable_execution: bool = False
     supports_deferrable: bool = False
+    durable_mechanism: Literal["marker", "resumable_mixin"] | None = None
+    durable_gating_provider: str | None = None
+    durable_gating_class: str | None = None
+    durable_since_version: str | None = None
+    durable_default: bool | None = None

Review Comment:
   It comes out `true` as well, for `PowerBIDatasetRefreshOperator`. That one 
takes `durable: bool = True` from `ResumableJobMixin` and never names it 
itself. So `null` does not mean "on", it means "not declared in this operator's 
signature".
   
   The confusion is real though, just in a different place: `null` and `true` 
are two spellings of the same answer. Replaced the whole thing with 
`durable_opt_in: bool`, which is `true` only for an explicit `durable: bool = 
False`. That is the one case where you have to pass `durable=True` yourself. 
The page reads it directly now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to