Lee-W commented on PR #74695: URL: https://github.com/apache/airflow/pull/74695#issuecomment-6758728111
> Should the prefix handling logic be gathered into one place? Currently many toolsets have their own logic and some duplicates. `SQLToolset`, `DataFusionToolset`, `ObjectStorageToolset` and `SandboxToolset` now share the prefix handling through `ToolPrefixMixin`, and `HookToolset` shares the identifier check through `validate_tool_prefix`. Tool names, toolset ids and error messages are unchanged, since the ids end up in durable journal step names. `MCPToolset` is left out on purpose: it hands the prefix to pydantic-ai's `prefixed()`, and adding the identifier check there would be new behavior. `HookToolset` also keeps its deprecated `tool_name_prefix` path as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
