dabla commented on PR #76793: URL: https://github.com/apache/airflow/pull/76793#issuecomment-6760975028
One more thing, outside this PR's change, so it isn't part of the review. Writing it down so it's on record. Below Airflow 3.3, the compat `ResumableJobMixin` warns "`durable` has no effect on Airflow versions below 3.3" for any explicit value, `False` included ([`_resumable_job_mixin.py#L44`](https://github.com/apache/airflow/blob/dfe9cc6ef3c1ab508ae06e7e945d62d810ab23df/providers/common/compat/src/airflow/providers/common/compat/_resumable_job_mixin.py#L44)). With this PR, `default_args` now reaches `durable`. So a DAG that sets `default_args={"durable": False}` to opt out of the durable default gets that warning on every PowerBI task, even though `False` is exactly what happens on those versions. The other `ResumableJobMixin` operators from #71531 already do the same. `MSGraphAsyncOperator` handles `durable` itself and only warns when it is `True` ([`msgraph.py#L181`](https://github.com/apache/airflow/blob/dfe9cc6ef3c1ab508ae06e7e945d62d810ab23df/providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/msgraph.py#L181-L182)). If it's worth changing, it would be a one-line change in the compat mixin (`if durable:` instead of `if durable is not None:`), in its own PR. Up to you whether to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
