sdaberdaku commented on PR #74740:
URL: https://github.com/apache/airflow/pull/74740#issuecomment-6763085171

   > What does this look like in the UI when it ends up skipping please?
   
   Good question, and it turned up two gaps. The reason a policy gave for 
skipping was not shown anywhere outside the logs, and it was not even stored: 
the Execution API kept `retry_reason` only for failed tasks. Both are fixed in 
847d774965.
   
   A task skipped by a retry policy now looks like this:
   
   **Task instance header** shows the reason as the first stat, the same way it 
does for a policy `FAIL` or `RETRY`:
   
   <img width="1700" height="800" alt="Image" 
src="https://github.com/user-attachments/assets/3b69c2cb-6a7d-4b76-a08b-b5261095f538";
 />
   
   **Details tab** has a "Reason for state" row:
   
   <img width="1700" height="800" alt="Image" 
src="https://github.com/user-attachments/assets/b1557c5b-161b-4e7d-9171-ec0c7da6122f";
 />
   
   **Run view** is the same as for `AirflowSkipException`: the task and its 
downstream are skipped and the run succeeds:
   
   <img width="1700" height="800" alt="Image" 
src="https://github.com/user-attachments/assets/fe78ef34-30c0-4978-8244-a597facb02a7";
 />
   
   A task skipped any other way (`AirflowSkipException`, a skipped upstream) 
has no reason stored, so it looks as it does today.
   
   One thing to be aware of: the log still shows the original exception as 
`Task failed with exception` with its traceback, followed by `Retry policy 
decision action=skip reason=...`. That is the same path `FAIL`, `RETRY` and 
`RESCHEDULE` go through, since the policy is only consulted after the exception 
is logged. I left it as is, but I'm happy to change it if you think an ERROR 
line on a skipped task is misleading.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to