VladaZakharova commented on PR #74236: URL: https://github.com/apache/airflow/pull/74236#issuecomment-6763702092
> The secondary-before-primary ordering from the last round works and is tested, but `force=True` can delete instances the tool filtered out, and I'd like that settled before merge (inline). > > **Smaller observations** > > * The PR description is only the template, and the commit message is only the title. The Dataform `curl` fix is a separate behaviour change, so please describe it there too: the provider changelog is generated from `git log`. > * Two more notes are inline: lookup errors abort the run, and the `curl` fix is applied twice. > > > _This review was drafted by an AI-assisted tool and > > confirmed by an Apache Airflow maintainer. The findings > > below are observations, not blockers; an Apache Airflow > > maintainer — a real person — will take the next look at the > > PR. If you think a finding is mis-applied, please reply on > > the PR and a maintainer will weigh in._ > > _More on how Apache Airflow handles maintainer review:_ > > [Contributing guide](https://github.com/apache/airflow/tree/main/contributing-docs). > > Drafted-by: Claude Code (Opus 5.5); reviewed by `shahar1` before posting Thanks, all addressed. Clusters are now skipped (with the reason printed) when any of their instances isn't in the resources passed to handle, so force=True can no longer delete a protected or too-young instance; the README documents it. Lookup errors are caught as GoogleAPICallError: an unreadable type is treated as primary, and a cluster whose instances can't be listed is skipped. The curl signature change is reverted, and the test now checks that a Dataform deleter sends curl -X DELETE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
