meel-ayush commented on code in PR #76555:
URL: https://github.com/apache/airflow/pull/76555#discussion_r4523902774
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -1179,8 +1179,21 @@ def handle_requests(self, log: FilteringBoundLogger) ->
Generator[None, _Request
try:
msg =
self.decoder.validate_python(self._deserialize_request(request.body))
- except Exception:
+ except Exception as e:
log.exception("Unable to decode message", body=request.body)
+ with suppress(Exception):
Review Comment:
Yes, it's broad by design. If anything fails during deserialization or model
validation (malformed msgpack, missing fields, or unrecognized types), letting
it crash the loop or skipping the response without replying deadlocks the child
process on recv(4). Returning GENERIC_ERROR ensures the child always unblocks
and terminates cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
