olayiwola-gbenga commented on PR #74664: URL: https://github.com/apache/airflow/pull/74664#issuecomment-6771842506
> The reattach and deferrable flow reads well, but recovering from a completed export can report success for an export this task never ran, and I'd like that settled before merge. CI is green at this head. I reviewed by reading the code and did not run it against a real Firestore database. > > ### Smaller observations > * **Docs (minor).** `providers/google/docs/operators/firebase/firestore.rst` and the `example_firestore.py` system test don't show `reattach_on_restart` or `deferrable`. From `providers/AGENTS.md`: "Keep `provider.yaml` metadata, docs, and tests in sync." A short how-to section and a deferrable task in the example would cover it. > * The remaining findings are inline: 1 major, 3 minor and 2 nits. > > > _This review was drafted by an AI-assisted tool and > > confirmed by an Apache Airflow maintainer. The findings > > below are observations, not blockers; an Apache Airflow > > maintainer — a real person — will take the next look at the > > PR. If you think a finding is mis-applied, please reply on > > the PR and a maintainer will weigh in._ > > _More on how Apache Airflow handles maintainer review:_ > > [Contributing guide](https://github.com/apache/airflow/tree/main/contributing-docs). Thank you, I Updated firestore.rst and example_firestore.py to include a deferrable mode example and document reattach_on_restart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
