pingzh commented on a change in pull request #7141: [AIRFLOW-6544] add log_id
to end_of_log mark log record
URL: https://github.com/apache/airflow/pull/7141#discussion_r369883128
##########
File path: airflow/utils/log/es_task_handler.py
##########
@@ -255,7 +256,9 @@ def close(self):
# Mark the end of file using end of log mark,
# so we know where to stop while auto-tailing.
- self.handler.stream.write(self.end_of_log_mark)
+ if self.write_stdout:
+ print()
+ self.handler.emit(logging.makeLogRecord({'msg': self.end_of_log_mark}))
Review comment:
> this works as long as you do not put white spaces into your
end_of_log_mark. I think you would just ask for troubles by putting white space
characters into the end-of-log mark.
I am not sure why using white space will cause troubles.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
