ramitkataria opened a new pull request, #76848:
URL: https://github.com/apache/airflow/pull/76848
The Bedrock, Comprehend, Kinesis Analytics and OpenSearch Serverless sensors
resumed from deferral into poke(), which ignores the trigger event. When the
trigger gave up while the resource was still in an intermediate state (waiter
attempts exhausted, or a non-retriable API error such as an expired token),
that single poke returned False and the task was marked successful, so
downstream tasks ran against a resource that was not ready.
This surfaced in the example_bedrock_batch_inference system test: runs whose
credentials expired during the wait passed in deferrable mode while the batch
inference job was still in Submitted, and failed in non-deferrable mode.
These sensors now fail on a trigger error, as the other deferrable AWS
sensors do. The error is an AirflowException subclass so that soft_fail and
never_fail keep applying on resume.
ComprehendCreateDocumentClassifierCompletedSensor still enforces
fail_on_warnings after a successful trigger, which it previously did through
the resumed poke. A deferred sensor no longer pushes the poke result as its
return_value XCom, which matches non-deferrable mode.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
